(Fixes #420) Fix false positive in no-side-effect-in-cp #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvfritz
approved these changes
May 18, 2018
There was a problem hiding this comment.
This looks like a nice improvement! I don't think it necessarily needs to be part of this PR, but playing around I tried adding a few more test cases and I noticed test8 and test9 below don't current trigger any warnings.
diff --git a/tests/lib/rules/no-side-effects-in-computed-properties.js b/tests/lib/rules/no-side-effects-in-computed-properties.js
index 3eadc45..b8088b8 100644
--- a/tests/lib/rules/no-side-effects-in-computed-properties.js
+++ b/tests/lib/rules/no-side-effects-in-computed-properties.js
@@ -173,6 +173,22 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
},
test6() {
return this.something.keys.sort()
+ },
+ test7() {
+ this.types.forEach(c => {
+ this.something[c.category] = c
+ })
+ return {}
+ },
+ test8() {
+ this.types.forEach(c => {
+ globalVar = c
+ })
+ return {}
+ },
+ test9() {
+ globalVar = this.something
+ return {}
}
}
})`,
@@ -198,6 +214,15 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
}, {
line: 25,
message: 'Unexpected side effect in "test6" computed property.'
+ }, {
+ line: 29,
+ message: 'Unexpected side effect in "test7" computed property.'
+ }, {
+ line: 35,
+ message: 'Unexpected side effect in "test8" computed property.'
+ }, {
+ line: 40,
+ message: 'Unexpected side effect in "test9" computed property.'
}]
},
{If it's easy to fix, it could be in this PR. Otherwise, maybe a separate one. What do you think?
|
Let's do it in separate PR, you can fire an issue to discuss it @chrisvfritz. Although everything about this rule is a balance between being useful and not full of false positives. But we can discuss ofc :) |
michalsnik
deleted the
fix-no-side-effect-in-computed-property-false-positive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #420, by introducing parser that simplifies given MemberExpression or CallExpression to version that can be properly verified in terms of potential side-effect in the chain.
So for example this kind of code:
Is being simplified to this:
And now we can properly check for potential side-effects in the given chain without potential false-positives hidden in inner scopes.